Is twisted safe?

GHSA-c2jg-hw38-jrqq

The Twisted Web HTTP 1.1 server, located in the twisted.web.http module, parsed several HTTP request constructs more leniently than permitted by RFC 7230:

• The Content-Length header value could have a + or - prefix.
• Illegal characters were permitted in chunked extensions, such as the LF (\n) character.
• Chunk lengths, which are expressed in hexadecimal format, could have a prefix of 0x.
• HTTP headers were stripped of all leading and trailing ASCII whitespace, rather than only space and HTAB (\t).

This non-conformant parsing can lead to desync if requests pass through multiple HTTP parsers, potentially resulting in HTTP request smuggling.

You may be affected if:

• You use Twisted Web's HTTP 1.1 server and/or proxy
• You also pass requests through a different HTTP server and/or proxy

The specifics of the other HTTP parser matter. The original report notes that some versions of Apache Traffic Server and HAProxy have been vulnerable in the past. HTTP request smuggling may be a serious concern if you use a proxy to perform request validation or access control.

The Twisted Web client is not affected. The HTTP 2.0 server uses a different parser, so it is not affected.

The issue has been addressed in Twisted 22.4.0rc1 and later.

Other than upgrading Twisted, you could:

• Ensure any vulnerabilities in upstream proxies have been addressed, such as by upgrading them
• Filter malformed requests by other means, such as configuration of an upstream proxy

This issue was initially reported by Zhang Zeyu.